Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade knative/pkg to latest #809

Closed

Conversation

evankanderson
Copy link
Member

Fixes knative/eventing-contrib#190
Related knative/pkg#193

Proposed Changes

  • Upgrades knative/pkg. I had to update a few files to match the pkg/cloudevents package upgrade, but this does not move event handling to v0.2 CloudEvents. (Most of eventing does not use the cloudevents library right now anyway.)

Release Note

Removed the `Severity: Error` field from Conditions which was needlessly alarming human readers for conditions with Status=True.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 13, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 13, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@evankanderson evankanderson changed the title All versions to all people Upgrade knative/pkg to latest Feb 13, 2019
@evankanderson
Copy link
Member Author

Obsoleted by #711 which is new enough to get the changes desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants