-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create generic statsReporter in metrics package #8084
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
…ariables and methods for broker filter's stat_reporter - 1
@Leo6Leo can you rebase? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @creydr I re-write the statsReport to make it more generic and moved it to the metrics package by following the suggestions you left here. Please let me know if this is on the right track, then I will proceed changing the statsReporter for channel, broker ingress... to use the new generic statsReporter. |
@Leo6Leo can you check on the failing tests? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8084 +/- ##
==========================================
+ Coverage 67.71% 67.74% +0.03%
==========================================
Files 370 371 +1
Lines 17946 17965 +19
==========================================
+ Hits 12152 12171 +19
Misses 5020 5020
Partials 774 774 ☔ View full report in Codecov by Sentry. |
Proposed Changes
Pre-review Checklist
Release Note
Docs