Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eventtype CRD to include .spec.reference.address #7935

Merged
merged 1 commit into from
May 22, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented May 22, 2024

Currently we see on some eventtype tests the following warnings in the dispatcher:

{"level":"warn","ts":"2024-05-22T17:19:09.574Z","logger":"inmemorychannel-dispatcher","caller":"logging/warning_handler.go:32","msg":"API Warning: unknown field \"spec.reference.address\"","commit":"0e14da4-dirty","knative.dev/pod":"imc-dispatcher-59cb79846b-vbsgx"}

This PR addresses it and adds the address field to the CRD, as described in https://github.com/knative/pkg/blob/99e1685a799787390ad8cb32bce249173cfda7a6/apis/duck/v1/knative_reference.go#L29-L56

@creydr creydr requested review from matzew and Cali0707 May 22, 2024 17:24
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.51%. Comparing base (7e1c082) to head (b5af2d3).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7935      +/-   ##
==========================================
+ Coverage   69.22%   69.51%   +0.28%     
==========================================
  Files         339      344       +5     
  Lines       19494    15996    -3498     
==========================================
- Hits        13494    11119    -2375     
+ Misses       5337     4191    -1146     
- Partials      663      686      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
Copy link

knative-prow bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9c0f9cc into knative:main May 22, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants