Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype a MQTT Source #7919
Prototype a MQTT Source #7919
Changes from 5 commits
f926ddb
2e36a40
f91dbad
86b00ed
d9d62a3
cd40d41
5038750
d456eb6
80ed20c
ba1a157
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 1 in cmd/mqttsource/main.go
GitHub Actions / style / Golang / Boilerplate Check (go)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably handle the error here, if we fail to set the data does it make sense to dispatch the event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll probably just log the error and return so the event would not be sent?
Check failure on line 1 in go.mod
GitHub Actions / verify / Verify Deps and Codegen
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.