Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.13] fix: imc dispatcher doesn't have duplicate reporting of metrics #7873

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[release-1.13] fix: imc dispatcher doesn't have duplicate reporting of metrics #7873

merged 1 commit into from
Apr 26, 2024

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #7870

:bug: The IMC dispatcher metrics now correctly record the metrics once per event when there is only one request scheme, instead of twice

@Cali0707 @knative-prow-robot
fix: imc dispatcher doesn't have duplicate reporting
83728c1 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Apr 25, 2024
Merged
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2024
matzew
matzew approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@knative-prow knative-prow bot merged commit 1b8b450 into knative:release-1.13 Apr 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @matzew @Cali0707