Add Harwayne as an approver. #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
requested review from
evankanderson,
grantr,
inlined,
scothis and
vaikas
knative-prow-robot
added
the
size/XS
|
/assign @vaikas-google |
|
Several of the example reviews are very well done -- thanks for taking a careful and patient eye on your reviews. I wanted to call out the following in particular: #624 |
|
Ping @vaikas-google. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Aug 28, 2020
* 🤖 CI was here...🔥 * Adding 1.8 operator to the 0.16 branch Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Doing some conformance too Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * changing sinkbinding config, and skipping tests Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Pin the DEPRECATED channel broker to the LAST release, like upstream does. Using 0.15.2 as _our_ last release Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Remove the DEPRECATED channel broker from the sed, we DO want only the old released images... for the replica 0 setting ;-) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I switched GitHub users from adamharwayne to Harwayne and am counting contributions from both.
From ROLES.md:
Earliest review: 2018-08-02, more than 3 months ago
#308
Reviewed 21 L, XL, or XXL PRs
adamharwayne size/L
adamharwayne size/XL
adamharwayne size/XXL
Harwayne size/L
Harwayne size/XL
Harwayne size/XXL
10 substantial examples:
Eventing
Eventing Sources
Merged 43 PRs
adamharwayne
Harwayne
Current eventing lead is @vaikas-google.
/cc @evankanderson
/cc @vaikas-google
/cc @scothis
/cc @grantr
/cc @inlined