Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RateLimiter to GCP PubSub channel to backoff retries on dispatch failures #775

Merged
merged 11 commits into from
Feb 6, 2019
Merged

Adding RateLimiter to GCP PubSub channel to backoff retries on dispatch failures #775

merged 11 commits into from
Feb 6, 2019

Conversation

nachocano
Copy link
Contributor

Proposed Changes

  • Added a RateLimiter to GCP PubSub channel in order to be able to backoff message retries when there is a dispatch failure. Using an exponential backoff as the default mechanism for now.
  • As the GCP PubSub tries to retry as soon as a message is nacked, we use the backoff to "delay" the nacking of unsuccessful deliveries. The actual retry is still taken care by GCP PubSub.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 31, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2019
@nachocano
Copy link
Contributor Author

/assign @Harwayne
/assign @grantr

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/gcppubsub/pkg/dispatcher/dispatcher/reconcile.go 100.0% 99.1% -0.9

@nachocano
Copy link
Contributor Author

/cc @Harwayne
/cc @grantr

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2019
Harwayne
Harwayne reviewed Feb 6, 2019
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

contrib/gcppubsub/pkg/dispatcher/dispatcher/reconcile_test.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
Harwayne
Harwayne reviewed Feb 6, 2019
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@vaikas
Copy link
Contributor

vaikas commented Feb 6, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@knative-prow-robot knative-prow-robot merged commit 9d5a378 into knative:master Feb 6, 2019
@nachocano nachocano mentioned this pull request Jun 3, 2020
Closed
matzew added a commit to matzew/eventing that referenced this pull request Aug 20, 2020
@matzew
Fixing the disabled image promotion for all branches (knative#775)
e2a4ae3 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request Sep 3, 2024
@mgencur @ctmphuongg @Cali0707
EventType tests verify the type under spec.reference (knative#7888) (k…
2f467a6 
…native#775)

* test ref

* test for reference

* format

* Update test/rekt/features/apiserversource/data_plane.go



* fix syntax

---------

Co-authored-by: Phuong Cao <88098962+ctmphuongg@users.noreply.github.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harwayne Harwayne Harwayne left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@scothis scothis Awaiting requested review from scothis

@grantr grantr Awaiting requested review from grantr

Assignees

@grantr grantr

@Harwayne Harwayne

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nachocano @knative-metrics-robot @vaikas @knative-prow-robot @Harwayne @grantr @googlebot