Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add channels to event lineage graph #7745

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Mar 6, 2024

Fixes #7682

Proposed Changes

  • Add channel to event lineage graph as a vertex
  • Add another vertex and edge to the graph if there is a DLS for the channel
  • Unit tests for both scenarios

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

knative-prow bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Mar 6, 2024

/cc @Leo6Leo @creydr @pierDipi

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.15%. Comparing base (c9de4b5) to head (a31d490).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7745      +/-   ##
==========================================
+ Coverage   69.11%   69.15%   +0.04%     
==========================================
  Files         339      339              
  Lines       19398    19429      +31     
==========================================
+ Hits        13406    13437      +31     
  Misses       5330     5330              
  Partials      662      662              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 6, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Mar 6, 2024

/retest-required

@knative-prow knative-prow bot merged commit 1ae172e into knative:main Mar 6, 2024
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Lineage: Map Channels to Graph Nodes
2 participants