Cache statefulset scale update/get requests #7651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
approved
Signed-off-by: Calum Murray <cmurray@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7651 +/- ##
==========================================
- Coverage 74.29% 74.01% -0.29%
==========================================
Files 262 262
Lines 15112 15172 +60
==========================================
+ Hits 11227 11229 +2
- Misses 3279 3337 +58
Partials 606 606 ☔ View full report in Codecov by Sentry. |
pierDipi
reviewed
Feb 2, 2024
pkg/scheduler/scheduler.go
Outdated
Comment on lines
183
to
185
| func (sc *ScaleCache) Reset() { | ||
| sc.entries = cache.NewExpiring() | ||
| } |
Signed-off-by: Calum Murray <cmurray@redhat.com>
|
/cc @pierDipi |
pierDipi
reviewed
Feb 6, 2024
pkg/scheduler/scheduler.go
Outdated
| @@ -114,3 +123,83 @@ type VPod interface { | |||
|
|
|||
| GetResourceVersion() string | |||
| } | |||
|
|
|||
| type ScaleCache struct { | |||
| lock sync.RWMutex //protects access to entries, entries itself is concurrency safe, so we only need to ensure that we correctly access the pointer | |||
There was a problem hiding this comment.
Let's be specific on what this lock is associated with, usually <name> + Mu
Suggested change
| lock sync.RWMutex //protects access to entries, entries itself is concurrency safe, so we only need to ensure that we correctly access the pointer | |
| entriesMu sync.RWMutex // protects access to entries, entries itself is concurrency safe, so we only need to ensure that we correctly access the pointer |
pierDipi
reviewed
Feb 6, 2024
pierDipi
reviewed
Feb 6, 2024
pierDipi
reviewed
Feb 6, 2024
pierDipi
reviewed
Feb 6, 2024
|
/cc @pierDipi |
|
/retest |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Cali0707
force-pushed
the
statefulset-cache
branch
from
795285e to
c76d64e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pierDipi do we want to backport this to 1.13? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps to fix the consumergroup issues we are seeing in ekb. At least some of the slow reconciliation is due to errors such as:
When we increased the client rate limit, these error logs were no longer present
Proposed Changes
Pre-review Checklist
Release Note