fix mt-broker-ingress watch Broker

[xiangpingjiang]

Fixes #7474

Proposed Changes

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

fix mt-broker-ingress  watch Broker

Docs

[knative-prow]

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fa15023) 76.12% compared to head (502c420) 76.12%.
Report is 8 commits behind head on main.

Files	Patch %	Lines
pkg/broker/ingress/ingress_handler.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7499   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files         260      260           
  Lines       14467    14467           
=======================================
  Hits        11013    11013           
  Misses       2888     2888           
  Partials      566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

/ok-to-test

[matzew]

/test reconciler-tests

[matzew]

/test reconciler-tests

[Cali0707]

Hey @xiangpingjiang sorry I missed this earlier when investigating the issue! It seems like when the brokers are first created sometimes the Address field is nil in the status, causing the ingress to panic. I added a suggestion for a fix to this, as well as checking that the broker itself is not nil just for safety.

[Cali0707]

/cherry-pick release-1.12

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/cherry-pick release-1.11

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

Thanks for fixing this @xiangpingjiang !

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@Cali0707: new pull request created: #7512

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@Cali0707: new pull request created: #7513

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.