-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch filters to use rfc-3339 for time string encoding #7466
Switch filters to use rfc-3339 for time string encoding #7466
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
/cc @pierDipi should we backport this? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7466 +/- ##
==========================================
- Coverage 76.79% 76.68% -0.11%
==========================================
Files 253 253
Lines 14098 14173 +75
==========================================
+ Hits 10826 10869 +43
- Misses 2732 2751 +19
- Partials 540 553 +13 ☔ View full report in Codecov by Sentry. |
/hold until I add some tests to make sure the issue is resolved |
Yes |
Signed-off-by: Calum Murray <cmurray@redhat.com>
/unhold |
Signed-off-by: Calum Murray <cmurray@redhat.com>
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/test reconciler-tests |
Fixes #7465
Currently, we are seeing some inconsistency on time comparisons with filters. This is because we are using a string representation of the time which is explicitly marked as:
CloudEvents spec states that we should use RFC-3339 for encoding timestamps as strings:
https://github.com/cloudevents/spec/blob/130ba0d183f5e45c1d141f5c1f272cf71d898623/cloudevents/spec.md?plain=1#L244
This PR switches our
time.Time.String
calls with code that converts thetime.Time
to RFC-3339 compliant strings.Proposed Changes
Pre-review Checklist
Release Note
Docs