-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring whether to allow cross namespaces Brokers configuration references #7455
Allow configuring whether to allow cross namespaces Brokers configuration references #7455
Conversation
Instead of always allowing to specify cross namespace configuration references for Broker allow users to configure whether to disallow such references as it might be problematic in multi tenant environments. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7455 +/- ##
==========================================
+ Coverage 76.72% 76.75% +0.03%
==========================================
Files 253 253
Lines 13903 13974 +71
==========================================
+ Hits 10667 10726 +59
- Misses 2702 2712 +10
- Partials 534 536 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you need to run codegen, also I was wondering - what happens if I have a broker in one namespace ns1
, which is allowed to send to other namespaces and it sends to a broker in namespace ns2
which is not allowed to send to other namespaces. What would happen to a reply in that scenario?
This configuration is only for control plane configurations isolation, cross namespace data plane communication is still allowed and need to be handled with a service mesh or eventually when OIDC + authorization are implemented since even with disallowing cross reference for sink, users can still use absolute URLs and pass the check on the references for subscriber/reply/sink. For example, I'd like to disallow using the same underlying Kafka cluster credentials from 2 different namespaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…tion references (knative#7455) * Allow configuring disallow cross namespaces Brokers configuration ref Instead of always allowing to specify cross namespace configuration references for Broker allow users to configure whether to disallow such references as it might be problematic in multi tenant environments. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Codegen Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…tion references (knative#7455) (#426) * Allow configuring disallow cross namespaces Brokers configuration ref Instead of always allowing to specify cross namespace configuration references for Broker allow users to configure whether to disallow such references as it might be problematic in multi tenant environments. * Codegen --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…tion references (knative#7455) * Allow configuring disallow cross namespaces Brokers configuration ref Instead of always allowing to specify cross namespace configuration references for Broker allow users to configure whether to disallow such references as it might be problematic in multi tenant environments. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Codegen Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…tion references (knative#7455) (#453) * Allow configuring disallow cross namespaces Brokers configuration ref Instead of always allowing to specify cross namespace configuration references for Broker allow users to configure whether to disallow such references as it might be problematic in multi tenant environments. * Codegen --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Instead of always allowing to specify cross namespace configuration references for Broker allow users to configure whether to disallow such references as it might be problematic in multi tenant environments.
Proposed Changes
Pre-review Checklist
Release Note
Docs