Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warnings for EventType v1beta1 #7453

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Add deprecation warnings for EventType v1beta1 #7453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4437688
Change structure of crd versions for ET
matzew Nov 15, 2023
0dd6e11
:lipstick: Add deprecation warning to v1beta1 resource version
matzew Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions config/core/resources/eventtype.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ spec:
group: eventing.knative.dev
versions:
- &version
name: v1beta1
name: v1beta2
served: true
storage: true
storage: false
subresources:
status: {}
schema:
Expand Down Expand Up @@ -155,9 +155,14 @@ spec:
type: string
jsonPath: ".status.conditions[?(@.type==\"Ready\")].reason"
- <<: *version
name: v1beta2
name: v1beta1
served: true
storage: false
storage: true
# This indicates the v1beta1 version of the custom resource is deprecated.
# API requests to this version receive a warning header in the server response.
deprecated: true
# This overrides the default warning returned to API clients making v1beta1 API requests.
deprecationWarning: "eventing.knative.dev/v1beta1 EventType is deprecated; see https://knative.dev/docs/eventing/event-registry/ for instructions to migrate to eventing.knative.dev/v1beta2 EventType"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew when I check the link here I couldn't find the instructions to migrate to the next eventtype. Should we add an issue to docs to add this, or am I missing it somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. it's the regular document, which discusses the ET in detail. that is IMO good enough

# v1beta1 schema is identical to the v1beta2 schema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this line, even though this v1beta1 is earlier than v1beta2, does omitting the schema still work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should it not?

names:
kind: EventType
Expand Down
Loading