-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide volume with OIDC token in SinkBinding #7444
Provide volume with OIDC token in SinkBinding #7444
Conversation
828cde6
to
e038171
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7444 +/- ##
==========================================
+ Coverage 76.76% 76.79% +0.02%
==========================================
Files 253 253
Lines 13916 14098 +182
==========================================
+ Hits 10683 10826 +143
- Misses 2700 2732 +32
- Partials 533 540 +7 ☔ View full report in Codecov by Sentry. |
0c149ac
to
fb1a053
Compare
/retest |
@pierDipi could you recheck? |
|
||
func (s *SinkBindingSubResourcesReconciler) reconcileOIDCTokenSecret(ctx context.Context, sb *v1.SinkBinding) error { | ||
logger := logging.FromContext(ctx) | ||
secretName := fmt.Sprintf("oidc-token-%s", sb.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is potentially longer than the max characters count, can we just use the SB name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 updated to use kmeta.ChildName()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Fixes #7323
Proposed Changes
/oidc/token
Pre-review Checklist
How to verify change
kn broker create my-broker --class MTChannelBasedBroker
kn source container create my-container-source --image gcr.io/knative-nightly/knative.dev/eventing/cmd/heartbeats:latest --env POD_NAME=pod-name --env POD_NAMESPACE=default --sink broker:my-broker
kubectl get deploy my-container-source-deployment -o yaml
kubectl get secret oidc-token-my-container-source-sinkbinding -ojsonpath='{.data.token}' | base64 -d
Release Note