Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto generation of Subscriptions identity service account and… #7338

Merged
merged 8 commits into from
Oct 16, 2023
+343 −54
Merged

Support auto generation of Subscriptions identity service account and… #7338

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37879fe
Support auto generation of Subscriptions identity service account and…
xiangpingjiang Oct 6, 2023
c9a58f4
fix unit test
xiangpingjiang Oct 6, 2023
54834d6
fix unit test
xiangpingjiang Oct 6, 2023
a754e2c
fix unit test
xiangpingjiang Oct 9, 2023
88014a7
Merge branch 'knative:main' into subscriptions
xiangpingjiang Oct 11, 2023
2972ed4
changes after rewiews
xiangpingjiang Oct 12, 2023
008d695
add globalResync
xiangpingjiang Oct 16, 2023
cb12b81
Update pkg/reconciler/subscription/controller.go
xiangpingjiang Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/reconciler/subscription/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ func NewController(
}
})

globalResync = func(obj interface{}) {
xiangpingjiang marked this conversation as resolved.
Show resolved Hide resolved
impl.GlobalResync(subscriptionInformer.Informer())
}

subscriptionInformer.Informer().AddEventHandler(controller.HandleAll(impl.Enqueue))

// Trackers used to notify us when the resources Subscription depends on change, so that the
Expand Down