Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global resync brokers on config-features changes #7126

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Global resync brokers on config-features changes #7126

merged 3 commits into from
Aug 1, 2023

Conversation

pierDipi
Copy link
Member

This will allow updating Brokers' addresses based on transport-encryption feature flag

@pierDipi
Global resync brokers on config-features changes
c875841 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot requested review from aliok and lionelvillard July 31, 2023 10:01
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2023
@pierDipi
Copy link
Member Author

/cc @creydr @matzew

@knative-prow knative-prow bot requested review from creydr and matzew July 31, 2023 10:02
@pierDipi
Copy link
Member Author

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.15% ⚠️

Comparison is base (248a471) 78.05% compared to head (c875841) 77.91%.
Report is 5 commits behind head on main.

❗ Current head c875841 differs from pull request most recent head 60ffc7e. Consider uploading reports for the commit 60ffc7e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7126      +/-   ##
==========================================
- Coverage   78.05%   77.91%   -0.15%     
==========================================
  Files         250      248       -2     
  Lines       13390    13320      -70     
==========================================
- Hits        10452    10378      -74     
- Misses       2405     2408       +3     
- Partials      533      534       +1
Files Changed Coverage Δ
pkg/reconciler/broker/controller.go 83.54% <28.57%> (-4.30%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

Flaky test: #7101

/retest

Leo6Leo
Leo6Leo reviewed Aug 1, 2023
View reviewed changes
pkg/reconciler/broker/controller.go Outdated
@@ -69,7 +69,13 @@ func NewController(
configmapInformer := configmapinformer.Get(ctx)
secretInformer := secretinformer.Get(ctx)

featureStore := feature.NewStore(logging.FromContext(ctx).Named("feature-config-store"))
var grCb func(obj interface{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does grCb stands for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"global resync channel brokers"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a longer name

@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 1, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@pierDipi pierDipi requested a review from Leo6Leo August 1, 2023 15:26
@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 1, 2023

@pierDipi lol the UI you mean the editor in GitHub?

@Leo6Leo
Copy link
Member

Leo6Leo commented Aug 1, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@pierDipi
Copy link
Member Author

pierDipi commented Aug 1, 2023

/test upgrade-tests

@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit de2e8ff into knative:main Aug 1, 2023
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #7134

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 1, 2023
Merged
knative-prow bot pushed a commit that referenced this pull request Aug 2, 2023
@knative-prow-robot @pierDipi
[release-1.11] Global resync brokers on config-features changes (#7134)
1a5f37c 
This is an automated cherry-pick of #7126

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing that referenced this pull request Aug 3, 2023
@knative-prow-robot @pierDipi
[release-1.11] Global resync brokers on config-features changes (knat…
6bb1205 
…ive#7134)

This is an automated cherry-pick of knative#7126

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot pushed a commit to openshift-knative/eventing that referenced this pull request Aug 4, 2023
@pierDipi @knative-prow-robot
[release-v1.11] Backport TLS fixes (#301)
bfc115a 
* [release-1.11] Watch config-features in IMC controller (knative#7133)

This is an automated cherry-pick of knative#7125

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* [release-1.11] Global resync brokers on config-features changes (knative#7134)

This is an automated cherry-pick of knative#7126

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
@creydr creydr mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabo1208 gabo1208 gabo1208 approved these changes

@aliok aliok Awaiting requested review from aliok

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@creydr creydr Awaiting requested review from creydr

@matzew matzew Awaiting requested review from matzew

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@gabo1208 gabo1208

@Leo6Leo Leo6Leo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierDipi @knative-prow-robot @Leo6Leo @gabo1208