Added Support for K_CA_CERTS in the heartbeats #6920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
knative-prow
bot
added
the
size/M
|
/cc @pierDipi |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6920 +/- ##
==========================================
- Coverage 79.79% 79.74% -0.06%
==========================================
Files 244 244
Lines 12702 12706 +4
==========================================
- Hits 10136 10132 -4
- Misses 2065 2071 +6
- Partials 501 503 +2 ☔ View full report in Codecov by Sentry. |
pierDipi
reviewed
May 5, 2023
pierDipi
reviewed
May 5, 2023
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
|
@pierDipi are these errors related? |
pierDipi
reviewed
May 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, Vishal-Chdhry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vishal Choudhary sendtovishalchoudhary@gmail.com
Fixes #6917
The cmd/heartbeats component now supports Eventing TLS by using the K_CA_CERTS environment variable in client.
Proposed Changes
Pre-review Checklist
Release Note
Docs