Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Remove v1 check for ConfigMap #6502

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Aug 30, 2022

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Proposed Changes

  • Remove the check for v1 as that's the main API version

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

:broom: Remove check for v1 API of ConfigMap as there is only v1 CMs

Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #6502 (53475af) into main (db235e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6502   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files         235      235           
  Lines       11714    11714           
=======================================
  Hits         9617     9617           
  Misses       1628     1628           
  Partials      469      469           
Impacted Files Coverage Δ
pkg/reconciler/broker/broker.go 77.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lionelvillard
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ceaae24 into knative:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants