Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary disable CE SQL validation to unblock the nightly job #6012

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

devguyio
Copy link
Contributor

Related to #6010

This should be reverted after cloudevents/sdk-go#748 is merged. This should unblock the nightly job.

Proposed Changes

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2021
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1/trigger_validation.go 94.4% 94.1% -0.3

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #6012 (ca33e14) into main (aab5298) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6012      +/-   ##
==========================================
- Coverage   82.38%   82.36%   -0.02%     
==========================================
  Files         221      221              
  Lines        7573     7565       -8     
==========================================
- Hits         6239     6231       -8     
  Misses        897      897              
  Partials      437      437              
Impacted Files Coverage Δ
pkg/apis/eventing/v1/trigger_validation.go 85.61% <ø> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab5298...ca33e14. Read the comment docs.

@devguyio
Copy link
Contributor Author

/retest

@devguyio
Copy link
Contributor Author

the flaky TestBrokerWithDLQ failure
/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants