Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire deadLetterChannel, use DeliveryStatus consistently #5746

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

evankanderson
Copy link
Member

Add DeliveryStatus to Channelable.

Fixes #5364

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • [na] E2E tests for any new behavior
  • [na] Docs PR for any user-facing impact
  • [na] Spec PR for any new API feature
  • [na] Conformance test for any change to the spec

Release Note

* Adds deadLetterSinkUri to the Channel status.
* Deprecates deadLetterChannel with a 1-year timer.

Docs

No docs needed; the only mention of deadLetterChannel is in the auto-generated docs.

Add DeliveryStatus to Channelable.
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 21, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #5746 (94c5642) into main (f031ba2) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5746      +/-   ##
==========================================
- Coverage   82.65%   82.62%   -0.04%     
==========================================
  Files         202      202              
  Lines        6326     6314      -12     
==========================================
- Hits         5229     5217      -12     
  Misses        758      758              
  Partials      339      339              
Impacted Files Coverage Δ
pkg/apis/duck/v1/channelable_types.go 97.95% <ø> (ø)
pkg/apis/duck/v1/delivery_types.go 91.66% <ø> (ø)
pkg/apis/duck/v1beta1/delivery_conversion.go 100.00% <ø> (ø)
pkg/apis/eventing/v1/broker_types.go 66.66% <ø> (ø)
pkg/apis/eventing/v1/trigger_types.go 100.00% <ø> (ø)
pkg/apis/messaging/v1/subscription_types.go 66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f031ba2...94c5642. Read the comment docs.

@lionelvillard
Copy link
Member

@evankanderson do you want to get this in or add the fix you mentioned in Slack in this PR?

@evankanderson
Copy link
Member Author

The other spec fix is in a completely different place for a different issue (Subscription's spec.subscriber being empty is permitted when we closed that in the spec).

This one is complete as is.

@lionelvillard
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e05ccfc into knative:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel go definitions: ¯\_(ツ)_/¯
3 participants