-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DeadLetterSink on Trigger status #5642
Conversation
Mistakenly hadn't added it to the CRD, so it was just getting dropped by the apiserver. Luckily this means we shouldn't have any backwards compatibility issues :).
Codecov Report
@@ Coverage Diff @@
## main #5642 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 200 200
Lines 6266 6266
=======================================
Hits 5184 5184
Misses 750 750
Partials 332 332
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel spoke to @pierDipi and it sounds like we can just merge, I'll PR to fix downstreams |
I mistakenly hadn't added it to the CRD, so it was just getting dropped by the apiserver as an unknown field.
Semi-fixes #5639, I think there still remains the problem that Broker doesn't have a
status.deadLetterSinkUri
as referenced by the specProposed Changes
Release Note