Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace exporting to mt broker #5634

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add trace exporting to mt broker #5634

merged 1 commit into from
Aug 16, 2021

Conversation

benmoss
Copy link
Member

@benmoss benmoss commented Aug 16, 2021

The MT Broker controller wasn't exporting traces, so downstream components would get trace span parents that never show up in your tracing system.

Proposed Changes

  • 🐛 Export traces generated by the mtbroker controller

Release Note

Traces are exported by the mtbroker controller

Before:
Screen Shot 2021-08-16 at 11 55 04 AM

After:
Screen Shot 2021-08-16 at 11 55 12 AM

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 16, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/broker/controller.go 88.9% 85.0% -3.9

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #5634 (645ae63) into main (0c41e6d) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5634      +/-   ##
==========================================
- Coverage   82.77%   82.73%   -0.05%     
==========================================
  Files         200      200              
  Lines        6258     6266       +8     
==========================================
+ Hits         5180     5184       +4     
- Misses        748      750       +2     
- Partials      330      332       +2     
Impacted Files Coverage Δ
pkg/reconciler/broker/controller.go 88.88% <0.00%> (-4.14%) ⬇️
cmd/event_display/main.go 57.89% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c41e6d...645ae63. Read the comment docs.

@lionelvillard
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@knative-prow-robot knative-prow-robot merged commit 72fae58 into knative:main Aug 16, 2021
@benmoss benmoss deleted the mtbroker-tracing branch August 16, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants