Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knativehistory was removed #5550

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Knativehistory was removed #5550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/rekt/features/channel/data_plane.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ func DataPlaneChannel(channelName string) *feature.Feature {
Must("The output MUST match the CloudEvent version of the Input.", todo).
MustNot("Channels MUST NOT alter an event that goes through them.", todo).
Must("All CloudEvent attributes, including the data attribute, MUST be received at the subscriber identical to how they were received by the Channel.", todo).
// except: The extension attribute knativehistory, which the channel MAY modify to append its hostname
Should("Every Channel SHOULD support sending events via Binary Content Mode or Structured Content Mode of the HTTP Protocol Binding for CloudEvents.", todo).
Must("Channels MUST send events to all subscribers which are marked with a status of ready: True in the channel's status.subscribers.", todo).
Must("The events MUST be sent to the subscriberURI field of spec.subscribers.", todo)
Expand Down