-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support KReference.Group
in Subscription.Spec.Channel
#5520
Support KReference.Group
in Subscription.Spec.Channel
#5520
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #5520 +/- ##
==========================================
- Coverage 82.62% 82.56% -0.06%
==========================================
Files 198 198
Lines 6117 6125 +8
==========================================
+ Hits 5054 5057 +3
- Misses 737 741 +4
- Partials 326 327 +1
Continue to review full report at Codecov.
|
LGTM |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
The following is the coverage report on the affected files.
|
Fixes #5086
Proposed Changes
KReference.Group
now can be used inSubscription.Spec.Channel
as wellPre-review Checklist
Release Note
Docs