Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KReference.Group in Subscription.Spec.Channel #5520

Merged

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Jun 17, 2021

Fixes #5086

Proposed Changes

  • 🎁 KReference.Group now can be used in Subscription.Spec.Channel as well

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact: N/A
  • Spec PR for any new API feature: N/A
  • Conformance test for any change to the spec: N/A

Release Note

:gift: `KReference.Group` now can be used in `Subscription.Spec.Channel` as well

Docs

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 17, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #5520 (0ce949d) into main (6adafe5) will decrease coverage by 0.05%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5520      +/-   ##
==========================================
- Coverage   82.62%   82.56%   -0.06%     
==========================================
  Files         198      198              
  Lines        6117     6125       +8     
==========================================
+ Hits         5054     5057       +3     
- Misses        737      741       +4     
- Partials      326      327       +1     
Impacted Files Coverage Δ
pkg/reconciler/subscription/subscription.go 79.05% <37.50%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adafe5...0ce949d. Read the comment docs.

@matzew
Copy link
Member

matzew commented Jun 21, 2021

LGTM

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/subscription/subscription.go 85.9% 85.3% -0.5

@lionelvillard
Copy link
Member

/lgtm

/cc @vaikas @n3wscott to make sure you see this.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@knative-prow-robot knative-prow-robot merged commit b312f0e into knative:main Jun 21, 2021
@slinkydeveloper slinkydeveloper deleted the kreference_group_sub_channel branch June 21, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Experimental] KReference.Group to avoid being explicit on the APIVersion
5 participants