Add permission to update namespaces/finalizer #5501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/XS
Codecov Report
@@ Coverage Diff @@
## main #5501 +/- ##
=======================================
Coverage 82.69% 82.69%
=======================================
Files 198 198
Lines 6098 6098
=======================================
Hits 5043 5043
Misses 731 731
Partials 324 324 Continue to review full report at Codecov.
|
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
|
this will be more relevant when #5495 is landing |
|
/unhold as #5495 is now merged |
knative-prow-robot
removed
the
do-not-merge/hold
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
add_webhook_finalizer
branch
from
f97c29c
to
adb4f55
Compare
|
see also knative/serving#11517 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Jun 15, 2021
(similar to knative/eventing#5501) This patch adds the permission to update `namespaces/finalizers`. Since knative/pkg#2098 added ownerRef refers to namespace for webhook, we need this permission. Without it, cluster which has a stricter RBAC rules gets the following error: ``` cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on ... ``` Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
pushed a commit
to knative-extensions/eventing-kafka-broker
that referenced
this pull request
Jun 15, 2021
…#1000) (similar to knative/eventing#5501) This patch adds the permission to update `namespaces/finalizers`. Since knative/pkg#2098 added ownerRef refers to namespace for webhook, we need this permission. Without it, cluster which has a stricter RBAC rules gets the following error: ``` cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on ... ``` Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
slinkydeveloper
pushed a commit
to slinkydeveloper/eventing-kafka-broker
that referenced
this pull request
Jun 18, 2021
…knative-extensions#1000) (similar to knative/eventing#5501) This patch adds the permission to update `namespaces/finalizers`. Since knative/pkg#2098 added ownerRef refers to namespace for webhook, we need this permission. Without it, cluster which has a stricter RBAC rules gets the following error: ``` cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on ... ``` Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #
Proposed Changes
(similar to knative/serving#11517)
This patch adds the permission to update
namespaces/finalizers.Since knative/pkg#2098 added ownerRef refers to namespace for webhook,
we need this permission. Without it, cluster which has a stricter RBAC
rules gets the following error:
Pre-review Checklist
Release Note
/cc @markusthoemmes @nak3
Docs