-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PingSource stored version is now v1 #5381
PingSource stored version is now v1 #5381
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5381 +/- ##
==========================================
- Coverage 82.65% 82.61% -0.05%
==========================================
Files 194 194
Lines 6002 6004 +2
==========================================
- Hits 4961 4960 -1
- Misses 717 720 +3
Partials 324 324
Continue to review full report at Codecov.
|
f11c51a
to
2670aad
Compare
/hold let's merge this one after 0.23 is released so that we don't have to deal with downgrade issues. |
0.23 is out. /unhold |
/test pull-knative-eventing-upgrade-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-eventing-conformance-tests |
Proposed Changes
Pre-review Checklist
Release Note
Docs