Update Sequence to use correct conditions.

[n3wscott]

Fixes #4929

• Fixed logic bug when setting sequence to a nil address
• Use ready condition of channel and not the addressable state of channels.
• Update conditions from False to Unknown when setting non-terminal conditions.

/kind cleanup

Sequence now displays conditions as `Unknown` rather than `False` for non-terminal condition states.

[codecov]

Codecov Report

Merging #5369 (ee00ab2) into main (f1f4615) will decrease coverage by 0.04%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main    #5369      +/-   ##
==========================================
- Coverage   82.65%   82.61%   -0.05%     
==========================================
  Files         194      194              
  Lines        6002     6004       +2     
==========================================
- Hits         4961     4960       -1     
- Misses        717      720       +3     
  Partials      324      324              

Impacted Files	Coverage Δ
pkg/apis/flows/v1/sequence_types.go	100.00% <ø> (ø)
pkg/apis/flows/v1/sequence_lifecycle.go	91.80% <84.61%> (-4.81%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f4615...ee00ab2. Read the comment docs.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/flows/v1/sequence_lifecycle.go	95.5%	91.3%	-4.2

[vaikas]

Just to make sure I understand correctly. This is equivalent because we inlined AddressStatus before and instead of inlining you changed it to be explicit? Is there a reason why this is not a pointer like what AddressStatus has?

https://github.com/knative/pkg/blob/main/apis/duck/v1/addressable_types.go#L64

[n3wscott]

I am doing what Broker does, we have both styles and because the inner url is a pointer, it seems like the wrapper to the addressable could be allowed to be not a pointer?

We should pick a style and make it consistent. The root issue might be https://github.com/knative/pkg/blob/main/apis/duck/v1/addressable_types.go#L64 has URL as not optional

[vaikas]

Yeah, should've been clearer. I saw there being inconsistencies also. But just wanted to make sure that my understanding is that there are no changes to wire format. We should probably vet these to make sure they are consistent, and make sure that we comment the duck properly since it says there to embed it like this (well, that's how I read it still).

[vaikas]

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment