remove v1alpha1 sources APIs

[lionelvillard]

Proposed Changes

• Remove APIServerSource and SinkBinding v1alpha1 APIs

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

:wastebasket: Remove APIServerSource and SinkBinding v1alpha1 APIs

Docs

[codecov]

Codecov Report

Merging #5317 (15d01ed) into main (e807987) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5317      +/-   ##
==========================================
- Coverage   83.68%   83.56%   -0.13%     
==========================================
  Files         243      233      -10     
  Lines        6896     6674     -222     
==========================================
- Hits         5771     5577     -194     
+ Misses        783      762      -21     
+ Partials      342      335       -7     

Impacted Files	Coverage Δ
pkg/adapter/apiserver/adapter.go	62.74% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc44024...15d01ed. Read the comment docs.

[n3wscott]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [n3wscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[n3wscott]

Can you followup with fixes for:

• eventing-kafka
• eventing-rabbitmq

[lionelvillard]

Kafka follow-up: knative-extensions/eventing-kafka#580

@n3wscott @vaikas rabbitmq has been broken for a while now. Can you take a look?

[vaikas]

I don't see the downstream for rabbitmq being broken before this PR?
Here's the last passing test:
https://github.com/knative/eventing/runs/2448237273?check_suite_focus=true

But your PR caused the break?

  go: downloading github.com/jmespath/go-jmespath v0.3.0
  knative.dev/eventing-rabbitmq/pkg/reconciler/source imports
  	knative.dev/eventing/pkg/apis/sources/v1alpha1: module knative.dev/eventing@latest found (v0.22.1, replaced by /home/runner/work/eventing/eventing/src/knative.dev/eventing), but does not contain package knative.dev/eventing/pkg/apis/sources/v1alpha1
  go: finding module for package knative.dev/eventing/pkg/apis/sources/v1alpha1
  knative.dev/eventing-rabbitmq/pkg/reconciler/source imports
  	knative.dev/eventing/pkg/apis/sources/v1alpha1: module knative.dev/eventing@latest found (v0.22.1, replaced by /home/runner/work/eventing/eventing/src/knative.dev/eventing), but does not contain package knative.dev/eventing/pkg/apis/sources/v1alpha1

But, in any case I'll fix it in rabbitmq.

[vaikas]

hehe, this was the root of the problem:
https://github.com/knative-sandbox/eventing-rabbitmq/blob/main/pkg/reconciler/source/controller.go#L27

And used here...
https://github.com/knative-sandbox/eventing-rabbitmq/blob/main/pkg/reconciler/source/controller.go#L67

Works, but it's using the wrong import.

[lionelvillard]

I was referring to this: knative-extensions/eventing-rabbitmq#273

[vaikas]

@lionelvillard ah yes, thanks :) Yeah, I meant the downstream UT here were not breaking, but the fact that we can't update the deps is being worked in here:
knative-extensions/eventing-rabbitmq#276