Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding dataplane conformance tests for Delivery Specs for Brokers. #5262

Merged
merged 28 commits into from
Apr 15, 2021
Merged

Adding dataplane conformance tests for Delivery Specs for Brokers. #5262

merged 28 commits into from
Apr 15, 2021

Conversation

n3wscott
Copy link
Contributor

No description provided.

Scott Nichols and others added 24 commits April 13, 2021 09:17
stub the tests
76e4769
@vaikas
testing tracking
89bf996
@vaikas
fill out topology strawman
b635254
@vaikas
stepfn -> feature
ddb6e22
@vaikas
stuff
a19e0d9
@vaikas
add more pseudo code
224e3af
Merge pull request #17 from vaikas/stub-tests-2
e1ca9f8 
Stub tests 2 - Just checkpointing some stuff, plus pseudo code so we can div/conq
@vaikas
add expected events helper
f57bdac
@vaikas
add unit tests, fix some logic errors
002a8cd
Merge pull request #18 from vaikas/moar-new-stuff
f2ec7ce 
Moar new stuff
update reconciler-test
f565d56
move to unit
eaa583b
init the same as the expected, pass
a2dca11
almost working
8217475
@vaikas
simplify
7409f61
@vaikas
rebase and small changes
f90729d
Merge pull request #19 from vaikas/moar-stub-tests
fecfb98 
Moar stub tests
@vaikas
wire retry through
ad81852
@vaikas
mrege / cutpaset fixes
259d6d7
Merge pull request #20 from vaikas/wire-retry
abadfa1 
wire retry through
@vaikas
fix off-by-one error + tests. remove unused pseudo code
3f22c75
Merge pull request #21 from vaikas/remove-crap
8a5ce1f 
fix off-by-one error + tests. remove unused pseudo code
cleanup
9d2efc9
adding back the other spec langauge
0744b3a
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Apr 14, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 14, 2021
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

Merging #5262 (b59161e) into main (fc115ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5262   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         243      243           
  Lines        6879     6879           
=======================================
  Hits         5733     5733           
  Misses        797      797           
  Partials      349      349

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc115ae...b59161e. Read the comment docs.

vaikas
vaikas approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@knative-prow-robot knative-prow-robot merged commit 71153e6 into knative:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas approved these changes

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n3wscott @knative-prow-robot @vaikas