-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust resources.requests of eventing-webhook #5112
Conversation
Welcome @faruryo! It looks like this is your first PR to knative/eventing 🎉 |
Hi @faruryo. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #5112 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 283 283
Lines 7957 7957
=======================================
Hits 6625 6625
Misses 958 958
Partials 374 374 Continue to review full report at Codecov.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.21 |
@pierDipi: new pull request created: #5125 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you @faruryo for the quick fix! Congratulations on your first contribution 😄 |
Fixes #4987
Proposed Changes
(Intel(R) Core(TM) i3-10110U CPU @ 2.10GHz)
Release Note
Docs