Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust resources.requests of eventing-webhook #5112

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

faruryo
Copy link
Contributor

@faruryo faruryo commented Mar 21, 2021

Fixes #4987

Proposed Changes

  • Adjust resources.requests of eventing-webhook
    • Respond to the fact that the eventing-webhook is set to HorizontalPodAutoscaler, which may scale the pod extra if CPU requests are too low.
    • Memory resources were also adjusted, as their usage is clearly higher than the current Requests.

eventing-webhook-resource

(Intel(R) Core(TM) i3-10110U CPU @ 2.10GHz)

Release Note

Fix excessive number of Replicas for eventing-webhook

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 21, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2021
@knative-prow-robot
Copy link
Contributor

Welcome @faruryo! It looks like this is your first PR to knative/eventing 🎉

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2021
@knative-prow-robot
Copy link
Contributor

Hi @faruryo. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #5112 (adce6fe) into main (2dcdb47) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5112   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files         283      283           
  Lines        7957     7957           
=======================================
  Hits         6625     6625           
  Misses        958      958           
  Partials      374      374           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dcdb47...adce6fe. Read the comment docs.

@vaikas
Copy link
Contributor

vaikas commented Mar 22, 2021

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2021
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@knative-prow-robot knative-prow-robot merged commit 33cc21a into knative:main Mar 22, 2021
@pierDipi
Copy link
Member

/cherry-pick release-0.21

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #5125

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grantr
Copy link
Contributor

grantr commented Mar 24, 2021

Thank you @faruryo for the quick fix! Congratulations on your first contribution 😄

@julz julz mentioned this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive number of Replicas for eventing-webhook
5 participants