[#4739] Update e2e channel defaults webhook test #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use "require.Nil" instead of "assert.Equal" for test setup and where we don't wish to retry. The latter notes a failure but doesn't fail immediately. This resulted in panics in subsequent sections of the broker defaults webhook test [knative#4717] and made it hard to pin point the reason. "require.Nil" will output the error and fail immediately making it easier to debug issues with test setup. Signed-off-by: Sameer Vohra <vsameer@vmware.com>
knative-prow-robot
added
size/S
Codecov Report
@@ Coverage Diff @@
## master #4790 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 291 291
Lines 8281 8281
=======================================
Hits 6729 6729
Misses 1143 1143
Partials 409 409 Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, xtreme-sameer-vohra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4739
Proposed Changes
we don't wish to retry. The latter notes a failure but doesn't fail
immediately. This resulted in panics in subsequent sections of the
broker defaults webhook test [Replace assert with require in test #4717] and made it hard to pin point
the reason. "require.Nil" will output the error and fail immediately
making it easier to debug issues with test setup.