Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.20] Use KO_YAML_FLAGS for multi-platform build #4771

Merged
merged 1 commit into from
Jan 22, 2021
Merged

[release-0.20] Use KO_YAML_FLAGS for multi-platform build #4771

merged 1 commit into from
Jan 22, 2021

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #4770

NONE

@nak3 @knative-prow-robot
Use KO_YAML_FLAGS for multi-platform build
2b68c6f 
Since acf65cf started using hack/generate-yamls.sh, the KO_FLAGS option
was not used correctly so `--platform=all` option was missed in release
manifest.

This patch fixes it.

Thank you @VIjayHP for reporting the issue.
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 22, 2021
@knative-prow-robot knative-prow-robot mentioned this pull request Jan 22, 2021
Merged
@google-cla
Copy link

google-cla bot commented Jan 22, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 22, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jan 22, 2021
@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2021
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021 •
edited
Loading

Codecov Report

Merging #4771 (2b68c6f) into release-0.20 (a414aee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-0.20    #4771   +/-   ##
=============================================
  Coverage         81.05%   81.05%           
=============================================
  Files               291      291           
  Lines              8218     8218           
=============================================
  Hits               6661     6661           
  Misses             1156     1156           
  Partials            401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a414aee...2b68c6f. Read the comment docs.

@vaikas
Copy link
Contributor

vaikas commented Jan 22, 2021

@nak3 would you mind appeasing the CLA bot?

1 similar comment
@vaikas
Copy link
Contributor

vaikas commented Jan 22, 2021

@nak3 would you mind appeasing the CLA bot?

@nak3
Copy link
Contributor

nak3 commented Jan 22, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jan 22, 2021
@knative-prow-robot knative-prow-robot merged commit 7a24f25 into knative:release-0.20 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knative-prow-robot @slinkydeveloper @vaikas @nak3