Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-submit #4707 #4730

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

grac3gao-zz
Copy link
Contributor

Fixes #

Proposed Changes

  • With alignment problem, 4707 was revert. Re-submit it.

Release Note

message receiver supports customized liveness and readiness check 

Docs

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 12, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 12, 2021
@grac3gao-zz
Copy link
Contributor Author

/assign @slinkydeveloper

re-submit #4707

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #4730 (4331047) into master (b1882d6) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4730      +/-   ##
==========================================
- Coverage   81.05%   81.02%   -0.03%     
==========================================
  Files         291      291              
  Lines        8220     8223       +3     
==========================================
  Hits         6663     6663              
- Misses       1156     1159       +3     
  Partials      401      401              
Impacted Files Coverage Δ
pkg/kncloudevents/message_receiver.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1882d6...4331047. Read the comment docs.

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@knative-prow-robot knative-prow-robot merged commit ff5109d into knative:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants