-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zhongduo (Jimmy Lin) as an approver #4691
Add zhongduo (Jimmy Lin) as an approver #4691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4691 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 291 291
Lines 8216 8216
=======================================
Hits 6661 6661
Misses 1154 1154
Partials 401 401 Continue to review full report at Codecov.
|
LGTM congrats!! |
Thanks for all the work! |
Good to have you Jimmy! We should call you Super Jimmy for how fast and thorough your reviews are! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devguyio, vaikas, zhongduo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Criteria from https://github.com/knative/community/blob/master/ROLES.md#approver
First review:
#4192 , Oct 2nd, 2020
Substantial PRs reviewed (size/L, size/XL and size/XXL): https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Azhongduo+commenter%3Azhongduo+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM
24
Examples:
#4519
#4460
#4474
#4655
#4192
#4493
#4517
#4474
#4233
#4659
49
https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Azhongduo+commenter%3Azhongduo
My own PRs (though not in the requirements): https://github.com/knative/eventing/pulls?q=is%3Apr+author%3Azhongduo
12
Nominated by an area lead with no objections from other leads:
@grantr