Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zhongduo (Jimmy Lin) as an approver #4691

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

zhongduo
Copy link
Contributor

@zhongduo zhongduo commented Jan 5, 2021

Criteria from https://github.com/knative/community/blob/master/ROLES.md#approver

Reviewer of the codebase for at least 3 months:

First review:
#4192 , Oct 2nd, 2020

Substantial PRs reviewed (size/L, size/XL and size/XXL): https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Azhongduo+commenter%3Azhongduo+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM

Primary reviewer for at least 10 substantial PRs to the codebase.

24

Examples:
#4519
#4460
#4474
#4655
#4192
#4493
#4517
#4474
#4233
#4659

Reviewed at least 30 PRs to the codebase

49

https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Azhongduo+commenter%3Azhongduo

My own PRs (though not in the requirements): https://github.com/knative/eventing/pulls?q=is%3Apr+author%3Azhongduo

12

Nominated by an area lead with no objections from other leads:
@grantr

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 5, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 5, 2021
@zhongduo
Copy link
Contributor Author

zhongduo commented Jan 5, 2021

/cc @vaikas @lionelvillard @devguyio

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #4691 (261e011) into master (109066f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4691   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files         291      291           
  Lines        8216     8216           
=======================================
  Hits         6661     6661           
  Misses       1154     1154           
  Partials      401      401           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109066f...261e011. Read the comment docs.

@lionelvillard
Copy link
Member

LGTM

congrats!!

@vaikas
Copy link
Contributor

vaikas commented Jan 6, 2021

Thanks for all the work!
/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2021
@devguyio
Copy link
Contributor

devguyio commented Jan 6, 2021

Good to have you Jimmy! We should call you Super Jimmy for how fast and thorough your reviews are!

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, vaikas, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3f2d693 into knative:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants