Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix module usage of vegeta and bump version #4668

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Fix module usage of vegeta and bump version #4668

merged 1 commit into from
Dec 17, 2020

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Dec 17, 2020 •
edited
Loading

As per title, this fixes the imports of vegeta to point at the correct module for Golang modules to resolve the version properly. While at it, also bump to the latest version.

/assign @slinkydeveloper

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 17, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/performance area/test-and-release Test infrastructure, tests or release labels Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020 •
edited
Loading

Codecov Report

Merging #4668 (5351d8d) into master (f3468d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4668   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         290      290           
  Lines        8176     8176           
=======================================
  Hits         6648     6648           
  Misses       1128     1128           
  Partials      400      400

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3468d1...5351d8d. Read the comment docs.

@slinkydeveloper
Copy link
Contributor

Sounds more a version bump than a module usage fix, anyway thanks for that!
Can you bump this in eventing-kafka too?

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@slinkydeveloper
Copy link
Contributor

/hold merge at your will

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@markusthoemmes markusthoemmes changed the title Fix module usage of vegeta Fix module usage of vegeta and bump version Dec 17, 2020
@markusthoemmes
Copy link
Contributor Author

@slinkydeveloper good point, adjusted the comment.

@zhongduo
Copy link
Contributor

Is there an issue link for the problem?

@markusthoemmes
Copy link
Contributor Author

@zhongduo no problem at all, just general housekeeping.

@zhongduo
Copy link
Contributor

@zhongduo no problem at all, just general housekeeping.

ah, sorry my bad, I thought you are "fixing" to a version. LOL
/lgtm

@markusthoemmes
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@knative-prow-robot knative-prow-robot merged commit 11b4b71 into knative:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@slinkydeveloper slinkydeveloper

@zhongduo zhongduo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/performance area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markusthoemmes @knative-prow-robot @slinkydeveloper @zhongduo