fix issue 4375

[vaikas]

Signed-off-by: Ville Aikas vaikas@vmware.com

Fixes #4375

Proposed Changes

• Reconcile changes to delivery specs properly.

Release Note

- 🐛 Fix bug
Fix issue #4375 where we would not reconcile changes to reconcile policy or duration.

Docs

[slinkydeveloper]

/assign

[slinkydeveloper]

/lgtm
/approve

Thanks for this one!

[slinkydeveloper]

Sounds like you need to update fanout_message_handler_test.go too:

     fanout_message_handler_test.go:87: Unexpected diff   &fanout.Subscription{
          	Subscriber: &{Scheme: "http", Host: "subscriber.example.com"},
          	Reply:      &{Scheme: "http", Host: "reply.example.com"},
          	DeadLetter: &{Scheme: "http", Host: "dls.example.com"},
          	RetryConfig: &kncloudevents.RetryConfig{
          		RetryMax:      3,
        - 		BackoffDelay:  nil,
        + 		BackoffDelay:  &"PT1S",
        - 		BackoffPolicy: nil,
        + 		BackoffPolicy: &"linear",
          		... // 2 ignored fields
          	},
          } 

[codecov]

Codecov Report

Merging #4405 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4405      +/-   ##
==========================================
+ Coverage   81.06%   81.10%   +0.03%     
==========================================
  Files         281      281              
  Lines        7964     7963       -1     
==========================================
+ Hits         6456     6458       +2     
+ Misses       1122     1119       -3     
  Partials      386      386              

Impacted Files	Coverage Δ
...iler/inmemorychannel/dispatcher/inmemorychannel.go	92.68% <ø> (ø)
pkg/kncloudevents/message_sender.go	64.28% <100.00%> (+1.32%)	⬆️
pkg/reconciler/source/config_watcher.go	60.46% <0.00%> (+2.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80806a...3d1facf. Read the comment docs.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kncloudevents/message_sender.go	63.9%	65.8%	1.9

[slinkydeveloper]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment