Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move fuzzer code to _test files #4399

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 27, 2020

Signed-off-by: Ville Aikas vaikas@vmware.com

Addresses #4398

Proposed Changes

  • Move our FuzzerFuncs to the roundtrip_test.go files so that they don't get baked into the resulting binaries.

Release Note

- 🧽 Update or clean up current behavior

Move fuzzer (test related code) to test files so they don't get baked into our binaries. Small reduction in binary size.

Docs

Signed-off-by: Ville Aikas <vaikas@vmware.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 27, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #4399 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4399      +/-   ##
==========================================
- Coverage   81.10%   81.06%   -0.05%     
==========================================
  Files         285      281       -4     
  Lines        8014     7964      -50     
==========================================
- Hits         6500     6456      -44     
+ Misses       1128     1122       -6     
  Partials      386      386              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24cc81...5b72264. Read the comment docs.

Signed-off-by: Ville Aikas <vaikas@vmware.com>
@slinkydeveloper
Copy link
Contributor

/assign

@vaikas
Copy link
Contributor Author

vaikas commented Oct 27, 2020

unrelated to this, existing datarace.
/test pull-knative-eventing-unit-tests

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit cae627d into knative:master Oct 27, 2020
@vaikas vaikas deleted the fuzzers_away branch October 27, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants