Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Knative history extension #4366

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #4295

Proposed Changes

  • Remove KnativeHistory extension

Release Note

KnativeHistory extension is not added anymore to events going through channels

Docs

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 22, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Oct 22, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@slinkydeveloper
Copy link
Contributor Author

/assign @grantr

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@vaikas
Copy link
Contributor

vaikas commented Oct 22, 2020

Looks like this failed:

ok  	knative.dev/eventing/pkg/adapter/apiserver/events	0.052s	coverage: 96.2% of statements
# knative.dev/eventing/pkg/channel [knative.dev/eventing/pkg/channel.test]
pkg/channel/message_receiver_test.go:123:32: undefined: EventHistory

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #4366 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4366      +/-   ##
==========================================
- Coverage   80.81%   80.79%   -0.02%     
==========================================
  Files         288      287       -1     
  Lines        8001     7984      -17     
==========================================
- Hits         6466     6451      -15     
+ Misses       1147     1146       -1     
+ Partials      388      387       -1     
Impacted Files Coverage Δ
pkg/channel/message_receiver.go 68.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3be5f...3999e31. Read the comment docs.

@slinkydeveloper
Copy link
Contributor Author

@vaikas Fixed

@vaikas
Copy link
Contributor

vaikas commented Oct 22, 2020

/lgtm
/approve
/hold
Adding a hold until the discussion is finished. Looks like that's slated for today.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Oct 25, 2020

I am +1 on removing it. The case in issue 4295 IMO describes very well, why it's perhaps not a good idea. Also, there is end-to-end tracing.

@vaikas
Copy link
Contributor

vaikas commented Oct 26, 2020

/unhold
Discussed in the WG meeting and in triage.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2020
@knative-prow-robot knative-prow-robot merged commit ecaaea7 into knative:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 431 occurs when there are too many flow steps
5 participants