-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Knative history extension #4366
Remove Knative history extension #4366
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
/assign @grantr |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Looks like this failed:
|
Codecov Report
@@ Coverage Diff @@
## master #4366 +/- ##
==========================================
- Coverage 80.81% 80.79% -0.02%
==========================================
Files 288 287 -1
Lines 8001 7984 -17
==========================================
- Hits 6466 6451 -15
+ Misses 1147 1146 -1
+ Partials 388 387 -1
Continue to review full report at Codecov.
|
@vaikas Fixed |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am +1 on removing it. The case in issue 4295 IMO describes very well, why it's perhaps not a good idea. Also, there is end-to-end tracing. |
/unhold |
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Fixes #4295
Proposed Changes
Release Note
Docs