Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused cruft from reconciler split #4318

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 14, 2020

Proposed Changes

  • When we split the broker reconciler into broker / trigger, some cruft was left over. My bad, removing...

Release Note

- 🧽 Update or clean up current behavior
Just clean up some unused fields from the mtbroker reconciler struct.

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 14, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/mtbroker/controller.go 90.5% 88.9% -1.6

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #4318 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4318      +/-   ##
==========================================
- Coverage   80.36%   80.35%   -0.01%     
==========================================
  Files         288      288              
  Lines        7910     7907       -3     
==========================================
- Hits         6357     6354       -3     
  Misses       1172     1172              
  Partials      381      381              
Impacted Files Coverage Δ
pkg/reconciler/mtbroker/broker.go 78.44% <ø> (ø)
pkg/reconciler/mtbroker/controller.go 93.02% <ø> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0889429...d2d3f37. Read the comment docs.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 733adb7 into knative:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants