Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set check retry function #4112

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Set check retry function #4112

merged 1 commit into from
Sep 25, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 24, 2020 •
edited
Loading

Part of #4111

This PR sets the CheckRetry function and add some unit tests.

Proposed Changes

  • Set check retry function

Release Note

- 🐛 Fix bug
Channels and Brokers correctly retry on non 2xx HTTP status codes

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 24, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2020
@pierDipi pierDipi mentioned this pull request Sep 24, 2020
Merged
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestChannelDeadLetterSinkV1Beta1/Channel-messaging.knative.dev/v1
test/e2e.TestChannelDeadLetterSinkV1Beta1/InMemoryChannel-messaging.knative.dev/v1
test/e2e.TestChannelDeadLetterSinkV1Beta1/InMemoryChannel-messaging.knative.dev/v1beta1
test/e2e.TestChannelDeadLetterSinkV1Beta1/Channel-messaging.knative.dev/v1beta1
test/e2e.TestChannelDeadLetterSinkV1Beta1
test/e2e.TestSequence/Channel-messaging.knative.dev/v1
test/e2e.TestSequence
test/e2e.TestParallel/Channel-messaging.knative.dev/v1

and 10 more.

@pierDipi pierDipi force-pushed the KNATIVE-4111 branch 2 times, most recently from e344acd to c1ae981 Compare September 24, 2020 21:40
@pierDipi
Set check retry function
c325b4c 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kncloudevents/message_sender.go 44.1% 63.9% 19.8

matzew
matzew approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 0c96da5 into knative:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierDipi @knative-test-reporter-robot @knative-metrics-robot @knative-prow-robot @matzew @googlebot