Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate the entire delivery spec to the Channel #4042

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Propagate the entire delivery spec to the Channel #4042

merged 2 commits into from
Sep 14, 2020

Conversation

pierDipi
Copy link
Member

The subscription reconciler didn't propagate the entire deliverySpec
to the channel, only the deadLetterSink was propagated.

Proposed Changes

  • Propagate the entire delivery spec to the Channel

Release Note

- 🐛 Fix bug
The subscription reconciler correctly propagates delivery configurations to the channel (`retry`, `backoffDelay`, `backoffPolicy`).

@pierDipi
Propagate the entire delivery spec to the Channel
725ead4 
The subscription reconciler didn't propagate the entire `deliverySpec`
to the channel, only the `deadLetterSink` was propagated.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 14, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 14, 2020
@pierDipi
Copy link
Member Author

/cc @slinkydeveloper @n3wscott

@slinkydeveloper
Copy link
Contributor

/assign

@pierDipi
Copy link
Member Author 

=== RUN   TestPersistedStore
    persisted_store_test.go:104: Timed out waiting for configmap creation.
--- FAIL: TestPersistedStore (4.00s)

/retest

@pierDipi
Copy link
Member Author

I'll backport it once it's approved.

slinkydeveloper
slinkydeveloper reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little nit but lgtm

pkg/reconciler/subscription/subscription.go Outdated Show resolved Hide resolved
@pierDipi
Apply suggestion
42ccc3e 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/subscription/subscription.go 76.3% 76.2% -0.0

@knative-prow-robot knative-prow-robot merged commit 5a54e9c into knative:master Sep 14, 2020
pierDipi added a commit to pierDipi/eventing that referenced this pull request Sep 14, 2020
@pierDipi
Propagate the entire delivery spec to the Channel (knative#4042)
e69c6f8 
* Propagate the entire delivery spec to the Channel

The subscription reconciler didn't propagate the entire `deliverySpec`
to the channel, only the `deadLetterSink` was propagated.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Apply suggestion

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi mentioned this pull request Sep 14, 2020
Merged
@matzew matzew mentioned this pull request Sep 14, 2020
Closed
knative-prow-robot pushed a commit that referenced this pull request Sep 14, 2020
@pierDipi
Propagate the entire delivery spec to the Channel (#4042) (#4044)
34de810 
* Propagate the entire delivery spec to the Channel

The subscription reconciler didn't propagate the entire `deliverySpec`
to the channel, only the `deadLetterSink` was propagated.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Apply suggestion

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@slinkydeveloper slinkydeveloper slinkydeveloper left review comments

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

@yolocs yolocs Awaiting requested review from yolocs

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierDipi @slinkydeveloper @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot