backport issue 3945 to .17 #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/M
knative-prow-robot
added
the
area/test-and-release
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests: |
|
/test pull-knative-eventing-integration-tests |
lberk
reviewed
Aug 27, 2020
| @@ -317,12 +317,13 @@ func BrokerV1Beta1ConsumerDataPlaneTestHelper( | |||
| event.SetSource(source) | |||
| msg := []byte(`{"msg":"Transformed!"}`) | |||
| transformPod := resources.EventTransformationPod( | |||
| "tranformer-pod", | |||
| "transformer-pod", | |||
|
/lgtm |
Merged
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Sep 1, 2020
* backport issue 3945 * backport 3918, 3900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #3945 to .17 release.
Also backport 3918, 3900. (helps with test flakes)
Proposed Changes
Release Note
Docs