Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pingsource v1alpha1 #3837

Merged
merged 1 commit into from
Aug 13, 2020
Merged

remove pingsource v1alpha1 #3837

merged 1 commit into from
Aug 13, 2020

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • remove pingsource v1alpha1 API

Release Note

- 🗑️ Remove PingSource v1alpha1 API

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 13, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 13, 2020
@nachocano
Copy link
Contributor

/lgtm
/approve

I guess it wasn't being served nor stored so it should be ok?
Shall we remove the other v1alpha1 core sources in next release as well? Or we need to mark them served and stored false first?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lionelvillard
Copy link
Member Author

@nachocano as soon as there is a migration job in place it should be fine. Here an example: https://github.com/knative/eventing/tree/release-0.16/config/pre-install/v0.16.0

@knative-prow-robot knative-prow-robot merged commit 2983f45 into knative:master Aug 13, 2020
@lionelvillard lionelvillard deleted the remove-pingsource-v1alpha1 branch September 3, 2020 15:29
@lionelvillard lionelvillard restored the remove-pingsource-v1alpha1 branch September 3, 2020 15:42
@lionelvillard lionelvillard deleted the remove-pingsource-v1alpha1 branch September 3, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chizhg chizhg Awaiting requested review from chizhg

@lberk lberk Awaiting requested review from lberk

Assignees

@nachocano nachocano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lionelvillard @nachocano @knative-prow-robot @googlebot