Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ApiServerSource always produce reconciler events per reconciler loop. #3693

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Drop ApiServerSource always produce reconciler events per reconciler loop. #3693

merged 2 commits into from
Jul 23, 2020

Conversation

n3wscott
Copy link
Contributor

Proposed Changes

  • Do not produce reconciled-normal events always. This causes spam in the api server and results in n*deps for global resyncs, even for no-ops.

Release Note

For ApiServerSource, the Kubernetes event "ApiServerSourceReconciled" is no longer produced for clean runs of the ReconcileKind method.

relates to knative/pkg#1520

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 23, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
mattmoor
mattmoor reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/apiserversource/apiserversource.go 74.2% 74.0% -0.3

@n3wscott n3wscott changed the title Apiserversource newnormal Drop ApiServerSource always produce reconciler events per reconciler loop. Jul 23, 2020
@knative-prow-robot knative-prow-robot merged commit e83e316 into knative:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@liu-cong liu-cong Awaiting requested review from liu-cong

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n3wscott @knative-prow-robot @knative-metrics-robot @mattmoor @googlebot