Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the channel-broker configs and release files #3547

Merged
merged 1 commit into from
Jul 9, 2020
Merged

remove the channel-broker configs and release files #3547

merged 1 commit into from
Jul 9, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 9, 2020

Remove the configurations and release files that still have the channel based broker. The deployment we released last time turned it to zero. There's no need to continue to ship with that.

Proposed Changes

  • Remove channel based broker from the release scripts and associated configs.

Release Note

- 🧽 Update or clean up current behavior
action-required. You must manually delete the (previously scaled to 0 deployment):
metadata:	
  name: broker-controller	
  namespace: knative-eventing

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jul 9, 2020
@pierDipi pierDipi mentioned this pull request Jul 9, 2020
Merged
pierDipi
pierDipi approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

related: #3548

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 718898a into knative:master Jul 9, 2020
@vaikas vaikas deleted the remove-cbb-config branch July 9, 2020 13:49
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@steuhs steuhs Awaiting requested review from steuhs

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaikas @knative-prow-robot @pierDipi @googlebot