Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actually make channel.spec.channelspec immutable #3520

Merged
merged 1 commit into from
Jul 6, 2020
Merged

actually make channel.spec.channelspec immutable #3520

merged 1 commit into from
Jul 6, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 6, 2020

Fixes #3518

Proposed Changes

  • Actually wire through the immutable checks.
  • Remove the test which is invalid, because subscribers are not allowed to be set (changed a long time ago...)

Release Note

- 🐛 Fix bug
Make channel.spec.channeltemplate immutable as it should be.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 6, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1/channel_validation.go 95.8% 96.4% 0.6

n3wscott
n3wscott reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b1abc04 into knative:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@grantr grantr Awaiting requested review from grantr

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Channel.spec.channelspec is immutable, but not properly checked.
5 participants
@vaikas @knative-metrics-robot @knative-prow-robot @n3wscott @googlebot