apply k8s leader election graceful release fix in vendor #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
do-not-merge/work-in-progress
knative-prow-robot
added
size/XXL
knative-prow-robot
added
size/L
knative-prow-robot
added
size/S
lionelvillard
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
lionelvillard
changed the title
|
/lgtm |
|
@cr22rc: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mattmoor
reviewed
Jul 15, 2020
|
|
||
| # Patch k8s leader-election fixing graceful release | ||
| # More information: https://github.com/kubernetes/kubernetes/pull/91942 | ||
| patch vendor/k8s.io/client-go/tools/leaderelection/leaderelection.go hack/k8s-client-go.patch |
There was a problem hiding this comment.
Historically we've used git apply to avoid introducing new tooling dependencies here. This is making the auto-deps automation fail :(
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Aug 7, 2020
Eventing change: knative/eventing#3405 Upstream PR: kubernetes/kubernetes#88192 PKG issue: knative/pkg#1199
knative-prow-robot
pushed a commit
to knative/serving
that referenced
this pull request
Aug 7, 2020
Eventing change: knative/eventing#3405 Upstream PR: kubernetes/kubernetes#88192 PKG issue: knative/pkg#1199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3157
Proposed Changes
Release Note
Docs
More information: kubernetes/kubernetes#91942