Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtping now uses shared main adapter #3371

Merged
merged 1 commit into from
Jun 25, 2020
Merged

mtping now uses shared main adapter #3371

merged 1 commit into from
Jun 25, 2020

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Jun 22, 2020 •
edited
Loading

For #3157

Proposed Changes

  • Top-level cmd uses shared main adapter instead of shared main controller
  • No more hot config files reloading

Release Note

Docs

Depends on #3370.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@lionelvillard lionelvillard mentioned this pull request Jun 23, 2020
Merged
@lionelvillard lionelvillard changed the title WIP: mtping now uses shared main adapter mtping now uses shared main adapter Jun 24, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/mtping/adapter.go Do not exist 100.0%
pkg/adapter/mtping/controller.go 81.0% 100.0% 19.0
pkg/reconciler/pingsource/pingsource.go 67.4% 67.3% -0.0

@cr22rc
Copy link
Contributor

cr22rc commented Jun 24, 2020

/lgtm

@knative-prow-robot
Copy link
Contributor

@cr22rc: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aslom
Copy link
Member

aslom commented Jun 25, 2020

/assign

@aslom
Copy link
Member

aslom commented Jun 25, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@knative-prow-robot knative-prow-robot merged commit 9537c9c into knative:master Jun 25, 2020
lberk pushed a commit to lberk/eventing that referenced this pull request Jun 26, 2020
@lionelvillard @lberk
mtping now uses shared adapter main (knative#3371)
415b425
@lionelvillard lionelvillard deleted the mtping-shared-adapter branch September 3, 2020 15:32
@lionelvillard lionelvillard restored the mtping-shared-adapter branch September 3, 2020 15:43
@lionelvillard lionelvillard deleted the mtping-shared-adapter branch September 3, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harwayne Harwayne Awaiting requested review from Harwayne

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@aslom aslom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lionelvillard @knative-prow-robot @knative-metrics-robot @cr22rc @aslom @googlebot