Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement krshaped for sources types #3226

Merged
merged 2 commits into from
May 29, 2020
Merged

Conversation

whaught
Copy link
Contributor

@whaught whaught commented May 28, 2020

Issue #3221

Proposed Changes

  • implement krshaped for sources types

Release Note


Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 28, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2020
@whaught whaught changed the title implement krshaped for sources types Implement krshaped for sources types May 28, 2020
@lberk
Copy link
Member

lberk commented May 28, 2020

/assign

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1alpha2/apiserver_lifecycle.go 82.4% 83.3% 1.0
pkg/apis/sources/v1alpha2/apiserver_types.go Do not exist 100.0%
pkg/apis/sources/v1alpha2/container_lifecycle.go 83.3% 84.2% 0.9
pkg/apis/sources/v1alpha2/ping_lifecycle.go 85.7% 86.4% 0.6
pkg/apis/sources/v1alpha2/ping_types.go Do not exist 0.0%
pkg/apis/sources/v1alpha2/sinkbinding_lifecycle.go 97.8% 97.8% 0.0
pkg/apis/sources/v1alpha2/sinkbinding_types.go Do not exist 100.0%

@knative-prow-robot
Copy link
Contributor

@whaught: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage 86266df link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lberk
Copy link
Member

lberk commented May 29, 2020

/lgtm
(I can follow up with a ping_types_test shortly)

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
@whaught
Copy link
Contributor Author

whaught commented May 29, 2020

/assign @Harwayne

@lionelvillard
Copy link
Member

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@knative-prow-robot knative-prow-robot merged commit 0ccaefd into knative:master May 29, 2020
@whaught whaught deleted the and1 branch June 3, 2020 15:51
@lberk lberk mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants