-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch EventType reconciler to v1beta1 version #3200
Conversation
/hold The 0.15 release cut is soon, hold until after that is made |
"knative.dev/pkg/configmap" | ||
"knative.dev/pkg/controller" | ||
"knative.dev/pkg/tracker" | ||
|
||
"knative.dev/eventing/pkg/apis/eventing/v1alpha1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for here,
v1alpha1.SchemeGroupVersion.WithKind("Broker"), |
can we use beta1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the moment this is still using v1alpha1.Broker everywhere - this PR is intended only to update the EventType resource. Someone more familiar would have to explain if we ought to be reconciling v1beta1.Broker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we're still reconciling with v1alpha1 for Brokers since v1beta1 is lossy. We'll drop v1alpha1 support and let's do the move to v1beta1 as part of that.
The following is the coverage report on the affected files.
|
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas, whaught The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Fixes #
Proposed Changes
Release Note